On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> CmdLine::is_executable() looks wrong, surely an empty line is not executable. > > With this change, in DCmd::parse_and_execute() we will avoid needlessly > entering the code block to try and execute the command. > > DCmd tests all good: > make images test TEST="test/hotspot/jtreg/serviceability/dcmd > test/jdk/sun/tools/jcmd" Can a line ever be empty? If so we should have a test case for that. ------------- PR Review: https://git.openjdk.org/jdk/pull/20006#pullrequestreview-2157983442
