On Thu, 11 Jul 2024 14:39:47 GMT, Guoxiong Li <[email protected]> wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional commits since the last revision:
>>
>> - review
>> - Merge branch 'master' into pgc-vm-operation
>> - pgc-vm-operation
>
> src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 434:
>
>> 432: void ParallelScavengeHeap::do_full_collection_no_gc_locker(bool
>> clear_all_soft_refs) {
>> 433: bool maximum_compaction = clear_all_soft_refs;
>> 434: PSParallelCompact::invoke(maximum_compaction);
>
> The parameter `maximum_heap_compaction` of the method
> `PSParallelCompact::invoke` was changed to `clear_all_soft_refs` in
> [JDK-8334445](https://git.openjdk.org/jdk/pull/19763), so the variable
> `maximum_compaction` seems not necessary here.
If the variable `maximum_compaction` is removed, it may be better to use
`PSParallelCompact::invoke` directly and remove the method
`do_full_collection_no_gc_locker` (just like using `PSScavenge::invoke`
directly).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20077#discussion_r1674260428
