On Fri, 12 Jul 2024 02:23:02 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> formatting
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001.java
> line 171:
>
>> 169: if (!messageReceived) {
>> 170: throw new TestFailure("No Notification received.");
>> 171: } else {
>
> Nit: The "else" is not really needed. Removing it will simplify the change
> diff.
ok yes
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001.java
> line 180:
>
>> 178:
>> 179: log.display("poolObjectName : " + poolObjectName +
>> 180: " resultObjectName : " +
>> resultObjectName);
>
> Nit: It'd be nice to fix the incorrect indent (it was in original code).
right, have made a formatting update
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20146#discussion_r1675563598
PR Review Comment: https://git.openjdk.org/jdk/pull/20146#discussion_r1675563943
