On Mon, 22 Jul 2024 13:45:49 GMT, Sonia Zaldana Calles <[email protected]> 
wrote:

>> Hi all, 
>> 
>> This is a small patch to address 
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making 
>> `CodeCache::write_perf_map` aware of which output stream errors and warning 
>> message should be going to.
>> 
>> Testing: 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Adding comment

Looks good.  
Yes the DCmds in diagnosticCommand.cpp tend to use outputStream* output (or 
out) as a param, this may help make it more obvious what the stream is for.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20257#issuecomment-2243113330

Reply via email to