On Wed, 24 Jul 2024 18:01:15 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> Obsolete PreserveAllAnnotations flag which was deprecated in JDK 23. > > Testing: tier1,tier2,tier3,tier4,hs-tier5-svc Great cleanup - good to see all that complexity go! I think the test can be removed completely - see below. Thanks test/jdk/java/lang/instrument/RetransformRecordAnnotation.java line 32: > 30: * @run shell MakeJAR.sh retransformAgent > 31: * @run main/othervm -javaagent:retransformAgent.jar > -Xlog:redefine+class=trace RetransformRecordAnnotation > 32: * @run main/othervm -javaagent:retransformAgent.jar > -XX:+PreserveAllAnnotations -Xlog:redefine+class=trace > RetransformRecordAnnotation This test is described as: * @summary test that records with invisible annotation can be retransformed ``` which suggests to me the test can actually be deleted as it serves no purpose now there are no invisible annotations ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20315#pullrequestreview-2198083244 PR Review Comment: https://git.openjdk.org/jdk/pull/20315#discussion_r1690664957
