On Fri, 2 Aug 2024 23:36:05 GMT, Serguei Spitsyn <[email protected]> wrote:
>> The JVMTI Watch Field functions do not disable VTMS transitions with the >> `JvmtiVTMSTransitionDisabler`: >> - `SetFieldAccessWatch()` >> - `ClearFieldAccessWatch()` >> - `SetFieldModificationWatch()` >> - `ClearFieldModificationWatch()` >> so in the `recompute_enabled()` we could see that a vthread is mounted, but >> in the `EnterInterpOnlyModeClosure` handshake the thread could have been >> unmounted already. This is a root cause of failures with this assert. >> >> The fix is to disable transitions in the >> `JvmtiEventControllerPrivate::change_field_watch()` function. >> >> Testing: >> - TBD: submit mach5 tiers 1-6 > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > adjusted the JvmtiVTMSTransition_lock rank to safepoint-1 Marked as reviewed by pchilanomate (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/20413#pullrequestreview-2219581324
