On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`. > > `MEMFLAGS` implies that we can use more than one at the same time, but those > are exclusive values, so `MemType` is much more suitable name. > > There is a bunch of other related cleanup that we can do, but I will leave > for follow up issues such as [NMT: rename NMTUtil::flag to > NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836) I think it must have `NMT` somewhere in the name. `NMTGroup` sounds like there could more than one value set at one time, but that might be just me. `NMTCat` (and `NMTGroup`) lose the idea that `Type` should be in there somewhere. For ease of typing, I'm not fond of `NMT::MemType` but it has the appeal of being in a namespace... So I'm going with: NMT::MemType - 3 points NMT_MemType/NMTMemType(prefer for ease of typing) - 2 points and I'm skipping a 1 point assignment. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2315871575
