On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Move JVM implementation access flags that are not specified by the classfile >> format into Klass so we can shrink AccessFlags to u2 in a future change. >> >> Tested with tier1-7. >> >> NOTE: there are arm, ppc and s390 changes to this that are just a guess. >> Also, graal changes. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Add in graal flags and a comment. x86 and ARM interpreter code looks good, just one potential nit. src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 247: > 245: load_klass(t1, obj); > 246: ldrb(t1, Address(t1, Klass::misc_flags_offset())); > 247: tstw(t1, KlassFlags::_misc_is_value_based_class); Same here src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 694: > 692: load_klass(tmp, obj_reg); > 693: ldrb(tmp, Address(tmp, Klass::misc_flags_offset())); > 694: tstw(tmp, KlassFlags::_misc_is_value_based_class); Should this just be `tst` instead of `tstw`? ------------- PR Review: https://git.openjdk.org/jdk/pull/20719#pullrequestreview-2270204138 PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737188858 PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737188530
