On Fri, 30 Aug 2024 00:07:50 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The fix improves Attch API protocol and implements updated protocol on > windows; shared code is ready to implement updated protocol support on other > platforms. > More detailed explanations on the 1st comment. > > Testing: tier1,tier2,tier3,tier4,hs-tier5-svc > manually tested backward compatibility (old tools can attach to current > VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u. Thanks for putting the details in a separate comment. That will make the emails that get sent for this PR much shorter. You use the word `symbols`, e.g., `each argument is resticted by 1024 symbols`. Do you really mean characters or bytes? Also thanks for including all the testing info! ------------- PR Comment: https://git.openjdk.org/jdk/pull/20782#issuecomment-2322099619 PR Comment: https://git.openjdk.org/jdk/pull/20782#issuecomment-2322100213
