On Tue, 15 Oct 2024 00:21:41 GMT, Alex Menkov <[email protected]> wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
>> manually tested backward compatibility (old tools can attach to current
>> VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u.
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> renamed JVM_EnqueueOperation2
>
> renamed JVM_EnqueueOperation2 to JVM_EnqueueOperation_v2 for consistency
> (per Serguei request)
src/hotspot/os/windows/attachListener_windows.cpp line 108:
> 106: size,
> 107: &nread,
> 108: nullptr); // not overlapped
Nit: Missed space after `fsuccess` at line 104.
Also, there is not cast `(DWORD)size` at line 106 as it is done in the
`WriteFile()` call at line 118.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1800848373
