On Tue, 1 Oct 2024 21:58:31 GMT, Chris Plummer <[email protected]> wrote:
> The following APIs are useful when debugging the debug agent. Calls to them
> can be added to the code as needed (temporarily) to aid in debugging issues.
> They were taken from `test/lib/jdk/test/lib/jvmti/jvmti_common.hpp` and
> modified to better fit the needs and coding style of the debug agent.
>
> char* translateThreadState(jint flags);
> char* getThreadName(jthread thread);
> char* getMethodName(jmethodID method);
> void printStackTrace(jthread thread);
> void printThreadInfo(jthread thread);
>
> I made use of them while working on a couple of recent bugs and found them
> very useful.
>
> Tested by running all debugging tests on all supported platforms, and also
> running tier2, tier3, and tier5 svc ci test tasks.
src/jdk.jdwp.agent/share/native/libjdwp/util.c line 1715:
> 1713: strcpy(tstate, str);
> 1714:
> 1715: return tstate;
Suggestion:
return tstate;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21299#discussion_r1783735671
