On Fri, 18 Oct 2024 00:40:38 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: move pop_count++ to the end of FramePop handler for more safety
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
> line 73:
>
>> 71:
>> 72: name = get_method_name(jvmti, jni, method);
>> 73: LOG("FramePop(%d) event from method: %s %s\n", pop_count, csig, name);
>
> I just noticed this pop_count reference here. Probably best to change it to
> pop_count + 1.
Nice catch. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805680619
