On Tue, 22 Oct 2024 15:52:27 GMT, Ramkumar Sunderbabu <[email protected]>
wrote:
> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge
> InMemoryJavaCompiler so that maintenance is easy.
>
> Testing done for
> Tiers 1,2,3
> test/hotspot/jtreg tests
I've occasionally run into this duplication and am happy you're fixing it.
test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java line 228:
> 226: }
> 227:
> 228: public static Map<String, byte[]> compile(Map<String, ? extends
> CharSequence> inputMap) {
Could the tests that use this 'compile' be easily fixed to use the below
version of 'compile' so you can delete this too?
-------------
PR Review: https://git.openjdk.org/jdk/pull/21641#pullrequestreview-2385856947
PR Review Comment: https://git.openjdk.org/jdk/pull/21641#discussion_r1811119284
