Re: RFR: 8341788: Fix ExceptionOccurred in hotspot [v2]

[Justin Lu]

On Mon, 28 Oct 2024 03:12:55 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   address other cases in Hotspot
>
> @justin-curtis-lu  you have missed a large number of usages:
> 
> ./share/prims/nativeEntryPoint.cpp:  guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/prims/methodHandles.cpp:    guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/prims/methodHandles.cpp:    guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/prims/methodHandles.cpp:    guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/prims/upcallLinker.cpp:  guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/prims/unsafe.cpp:  if (env->ExceptionOccurred()) {
> ./share/prims/upcallStubs.cpp:  guarantee(status == JNI_OK && 
> !env->ExceptionOccurred(),
> ./share/runtime/continuation.cpp:    guarantee(!env->ExceptionOccurred(), 
> "register jdk.internal.vm.Continuation natives");
> 
> 
> Thanks

Thanks for taking a look and catching those other occurrences @dholmes-ora. 
Addressed in 
https://github.com/openjdk/jdk/pull/21724/commits/c3ecb692c8fba1ce164169340a7d97785699e58f.
(Updated the JBS subtask issue as well to include those cases)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21724#issuecomment-2442911022