Re: RFR: 8344177: Remove SecurityManager and related calls from java.management [v3]

[Kevin Walls]

On Tue, 19 Nov 2024 14:52:21 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   add back checkClassLoader
>
> src/java.management/share/classes/sun/management/ManagementFactoryHelper.java 
> line 194:
> 
>> 192:             if (logging.isPresent()) {
>> 193:                 return Class.forName(logging.get(), className);
>> 194:             }  else {
> 
> Suggestion:
> 
>             } else {

ok thanks

> src/java.management/share/classes/sun/management/VMManagementImpl.java line 
> 249:
> 
>> 247: 
>> 248:         // construct PerfInstrumentation object
>> 249:         Perf perf =  Perf.getPerf();
> 
> Suggestion:
> 
>         Perf perf = Perf.getPerf();

ok yes, an existing double-space but we'll fix it 8-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22100#discussion_r1848571615
PR Review Comment: https://git.openjdk.org/jdk/pull/22100#discussion_r1848572302