On Wed, 20 Nov 2024 04:51:44 GMT, Chris Plummer <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - space
>> - Missed getBoolean
>
> src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandImpl.java
> line 152:
>
>> 150:
>> 151: public String execute(String[] args) {
>> 152: if (permission != null) {
>
> There is a lot of code that remains related to assigning a value to
> `permission`. It looks like it should also be removed.
Right, Permission in the class Wrapper, commandDescriptor manipulates a map
with permission info, there's native code that passes this between the JVM and
library code....
Would like to do that separately in:
JDK-8334493: Remove SecurityManager Permissions infrastructure from
DiagnosticCommands
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1850042500
