On Thu, 12 Dec 2024 12:41:28 GMT, Matthias Baesken <[email protected]> wrote:
>> We should output more information about the JVMTI agents in the hserr file.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> infos -> info
src/hotspot/share/runtime/os.cpp line 1128:
> 1126: #if INCLUDE_JVMTI
> 1127: // should return all kinds of JVMTI agents, but no xrun agents
> 1128: const JvmtiAgentList::Iterator it =JvmtiAgentList::agents();
Suggestion:
const JvmtiAgentList::Iterator it = JvmtiAgentList::agents();
src/hotspot/share/runtime/os.cpp line 1141:
> 1139: const char* optionsinfo = agent->options();
> 1140: const char* pathinfo = agent->os_lib_path();
> 1141: if (agent->is_dynamic()) dyninfo = "dynamic";
maybe just initialize it as
const char* dyninfo = agent->is_dynamic() ? "dynamic" : "";
(and the same for instrumentinfo/loadinfo/initinfo)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22706#discussion_r1883027329
PR Review Comment: https://git.openjdk.org/jdk/pull/22706#discussion_r1883030064
