On Wed, 18 Dec 2024 19:33:05 GMT, Alex Menkov <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: minor tweak in jvmti.xml update
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp
> line 500:
>
>> 498: cname = get_method_class_name(jvmti, jni, method);
>> 499:
>> 500: LOG("\nHit #%d: VirtualThreadUnmount #%d: enabling FramePop for
>> method: %s::%s on virtual thread: %p\n",
>
> The comment needs to be updated as NotifyFramePop is removed
> think we need a test for the functionality (a new one or update existing)
I've updated this test to request a duplicated `FramePop` event.
> The comment needs to be updated as NotifyFramePop is removed
I've updated this comment accordingly to the change above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22798#discussion_r1891097969
