On Thu, 23 Jan 2025 22:03:45 GMT, Dean Long <[email protected]> wrote:
> Overall the changes seem fine, however it would be nice if the vmStructs.cpp
> registration mechanism was modular and extensible, instead of monolithic.
> That would make it easier to register private types, or even types outside of
> libjvm.
I'm not too sure what you are suggesting here.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Thread.java line
> 92:
>
>> 90: public boolean isMonitorDeflationThread() { return false; }
>> 91: public boolean isAttachListenerThread() { return false; }
>> 92: public boolean isDeoptimizeObjectsALotThread() { return false; }
>
> Is this method used anywhere?
No, but I added it to be consistent with all the other JavaThread subclasses.
Actually none of these are used except for isCompilerThread and
isCodeCacheSweeperThread. The latter reference is irrelevant since there is no
longer a CodeCacheSweeperThread, and the former reference should be replaced
with isHiddenFromExternalView(). These are all things documented to fix as part
of [JDK-8348347](https://bugs.openjdk.org/browse/JDK-8348347), but in the
meantime I though it best to be consistent with existing code.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23279#issuecomment-2611148710
PR Review Comment: https://git.openjdk.org/jdk/pull/23279#discussion_r1927768244
