On Mon, 17 Feb 2025 06:24:35 GMT, Axel Boldt-Christmas <[email protected]>
wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove commented lines left by mistake
>
> src/hotspot/share/code/codeBlob.hpp line 308:
>
>> 306:
>> 307: class Vptr : public CodeBlob::Vptr {
>> 308: };
>
> Was this needed for some compiler? Or is it to be more explicit about the
> type hierarchy?
Thank you, @xmas92, for review and suggestions.
It is second (explicit type hierarchy). I think it should be explicitly
declared (even empty) because it is referenced in subclasses to avoid
confusion. And it could be useful in a future if we need other virtual methods.
Local build with `gcc` on Linux passed without it but I did not try to build
on other platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23533#discussion_r1958673128
