On Wed, 26 Feb 2025 04:17:54 GMT, Ashutosh Mehra <asme...@openjdk.org> wrote:
>> We are only interested in a rise that rose significantly above **both** the >> start and end point of the measurements. >> >> E.g.: >> - if we have this: start = 0, end = 20MB, peak = 20MB, this is not a >> temporary peak and we already know that the end usage is 20MB. >> - if we have this: start = 20MB, end = 0, peak = 20MB, this is not a >> temporary peak either, because we already know the starting footprint was >> 20MB. >> - but if we have start = 0, end = 0, peak = 20MB, this is interesting since >> if we just print start and end we will miss the fact that in between those >> times we had temporarily allocated 20MB. > > Thanks for the explanation. It would be great if some comment can be added, > possibly along with some example like the one in the previous comment, to > explain the meaning of `temporary_peak_size` and the corresponding > calculation. Will do. Thank you, @ashu-mehra ! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23530#discussion_r1976316773
