On Wed, 28 May 2025 03:47:04 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1172: > >> 1170: Handle _java_thread; >> 1171: JavaThread* _thread; >> 1172: int _depth; > > Nit: This naming is confusing and not consistent with naming in JVMTI and > other places. > The name `java_thread` is normally used for a `JavaThread*` object. > I would suggest to make it like this: > Handle _thread_h; // (or _thread_oop_h, or thread_obj_h) > JavaThread* _java_thread; fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113105546
