On Thu, 29 May 2025 19:50:33 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: add a call to ReleaseByteArrayElements to new function 
>> jni_array_to_jvmti_allocated
>
> test/lib/jdk/test/lib/jvmti/jvmti_common.hpp line 458:
> 
>> 456:       fatal(jni, "JNI GetArrayLength returned a non-positive value");
>> 457:     }
>> 458:     jbyte* jni_arr = jni->GetByteArrayElements(arr, nullptr);
> 
> need corresponding `ReleaseByteArrayElements` call

Good catch, thanks. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25422#discussion_r2115163012

Reply via email to