On Mon, 2 Jun 2025 08:07:38 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> There are a couple of jtreg tests, especially in the HS area, with very 
>> special assumptions about memory layout/sizes .
>> Those fail when the address sanitizer is configured ( --enable-asan ).
>> The change adds a way to tag those tests with 'requires' so that they can be 
>> avoided easily when running jtreg tests with ASAN enabled.
>> Adjusting the tests for "pleasing" the sanitizer is not always desired (if 
>> possible for some tests it can be done later) .
>> While at it, also same is also added for ubsan .
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   TestBreakSignalThreadDump has issues with asan

Changes requested by syan (Committer).

src/hotspot/share/prims/whitebox.cpp line 1100:

> 1098: #endif
> 1099: 
> 1100: bool WhiteBox::is_asan_enabled() {

Does we need `bool WhileBox::is_lsan_enable()` to check '--enable-lsan          
 enable LeakSanitizer' enable or not

test/hotspot/jtreg/TEST.ROOT line 94:

> 92:     vm.compiler2.enabled \
> 93:     vm.musl \
> 94:     vm.asan \

Do we need `vm.lsan`

-------------

PR Review: https://git.openjdk.org/jdk/pull/25575#pullrequestreview-2898739689
PR Review Comment: https://git.openjdk.org/jdk/pull/25575#discussion_r2127856663
PR Review Comment: https://git.openjdk.org/jdk/pull/25575#discussion_r2127857129

Reply via email to