On Fri, 6 Jun 2025 19:26:32 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Provide fallback for `stdin.encoding`
>
> BindServer.java is not used. It can be removed.
> 
> The changes in attach010Agent00.java are unnecessary because System.in has 
> been set to read from a file:
> 
> 35     private static final String inStreamFileName = 
> "AttachOnDemand.attach010.in";
> 60         FileInputStream newInputStream = new 
> FileInputStream(inStreamFileName);
> 61         System.setIn(newInputStream);

> @plummercj, shall I create a ticket+PR to
> 
>     1. remove `BindServer.java`, and
> 
>     2. revert changes to `attach010Agent00.java`?

Yes. It might be better to make them 2 PRs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25542#issuecomment-2956182139

Reply via email to