On Wed, 9 Jul 2025 04:16:22 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Thank you for the comment. >> The `NotifyFramePop` is similar to `SetBreakpoint`. I'd even prefer it to be >> named accordingly: `SetFramePop` instead of `NotifyFramePop`. >> Unfortunately, we can't easily rename API's by compatibility reasons. We >> enable any kinds of events with `SetEventNotoficationMode` but these are two >> cases where we need to be precise in setting the events. The `SetBreakpoint` >> is to set a breakpoint notification at a specific method's bytecode. The >> `NotifyFramePop` is to set `FramePop` notification for a specific frame. So, >> I' prefer to keep the terminology similar for `Breakpoints` and `FramePop` >> events. > > Chris, please, let me know if it is okay to keep this at is or you still want > an update for the `NotifyFramePop`. I understand what you are saying about the comparison to SetBreakpoint and that SetFramePop would have been a better name, but I don't see what this with the description. I said "set a FramePop event" doesn't sound right. Neither would "set a Breakpoint event". Also, the analogy with breakpoints doesn't really work when you consider that "a breakpoint" is meaningful, but "a FrampPop" does not. A breakpoint is a location in the code where a breakpoint event will be triggered when executed. That analogy doesn't really work with FramePop. We don't have a word similar to breakpoint that means "a frame marked for generating a FramePop event when popped". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26111#discussion_r2196234910
