On Thu, 10 Jul 2025 07:09:49 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> corrected one assert message
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4053:
>
>> 4051: }
>> 4052:
>> 4053: void VM_RedefineClasses::compute_matching_methods() {
>
> I can't see that this method actually still does anything useful. ??
I think it does:
- has asserts on added/deleted methods
- collects `_matching_old_methods` and `_matching_new_methods`
It seems that the `_old_methods` is same as `_matching_old_methods` and
`_new_methods` is same as `_matching_new_methods`. But I do not want to make a
deeper refactoring at this point until we have a decision on the full removal
of added/deleted methods support. It feels like we may need to keep some
support for lambda expression changes in class redefinitions/retransformations.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26232#discussion_r2199664342
