On Fri, 11 Jul 2025 08:30:57 GMT, Richard Reingruber <rr...@openjdk.org> wrote:

>> This pr moves the `notify()` call to the finally block to avoid the deadlock 
>> in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>> 
>> Testing was done with fastdebug and release builds on the main platforms and 
>> also on Linux/PPC64le and AIX.
>
> Richard Reingruber has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Last line is incomplete (acc. to POSIX). Add newline.
>  - `done` shouldn't be public

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26213#pullrequestreview-3011455649

Reply via email to