On Wed, 20 Aug 2025 07:34:04 GMT, David Holmes <[email protected]> wrote:
>> The test name would be >> test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/ExceptionOccurred/ExceptionOccurred.java >> I don't like this duplication. > > It is common to use a `Test` prefix on the actual file so we have directory > `foo`, containing `TestFoo.java` and `libFoo.cpp` (or 'libTestFoo.cpp`). The > point is that all the source files for one test reside in the same directory > unless a different structure is needed for some reason. Placing the native > code in its own subdirectory looks very odd to me. But of course there is no > general consistency here and it depends on who wrote the test cases and when. let me rename it to serviceability/jvmti/events/MethodExit/PendingException/TestMethodExitWithPendingException.java is ti make more clear? The "upcall" is used in the test only to call some method in the middle of exception handling. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26713#discussion_r2288464868
