On Wed, 27 Aug 2025 13:28:53 GMT, Coleen Phillimore <[email protected]> wrote:

>> Evgeny Astigeevich has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Symplify comments; Get JavaThread::current in variable
>
> Also sorry, I was reviewing this on my phone earlier this week and am just 
> back from being away.

@coleenp,

>  It's because I don't like the init-lock exposed this way

If we don't want to expose the init-lock to JVMTI, we can move `copy_bytecodes` 
to `InstanceKlass`.
IMO having `InstanceKlass::copy_bytecodes` sounds logical to me. 
Also I think `copy_bytecodes` should use `Rewriter::restore_bytecodes` instead 
of restoring bytecodes itself.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26863#issuecomment-3228548477

Reply via email to