On Thu, 4 Sep 2025 12:10:01 GMT, Fredrik Bredberg <[email protected]> wrote:
>> Since the integration of >> [JDK-8359437](https://bugs.openjdk.org/browse/JDK-8359437) the `LockingMode` >> flag can no longer be set by the user. After that, a number of PRs has been >> integrated which has removed all `LockingMode` related code from all >> platforms (except from zero, which is done in this PR). >> >> This PR removes `LockingMode` related code from the shared (non-platform >> specific) files. It also removes the `LockingMode` variable itself. >> >> Passes tier1-tier5 with no added problems. > > Fredrik Bredberg has updated the pull request incrementally with one > additional commit since the last revision: > > New version for Coleen Marked as reviewed by dholmes (Reviewer). src/hotspot/share/runtime/lightweightSynchronizer.cpp line 768: > 766: } > 767: > 768: // LightweightSynchronizer::inflate_locked_or_imse is used to to get an Suggestion: // LightweightSynchronizer::inflate_locked_or_imse is used to get an src/hotspot/share/runtime/lightweightSynchronizer.cpp line 822: > 820: // The JavaThread* locking parameter requires that the > 821: // locking_thread == JavaThread::current, or is suspended throughout > 822: // the call by some other mechanism. Suggestion: // The JavaThread* locking parameter requires that the locking_thread == JavaThread::current, // or is suspended throughout the call by some other mechanism. ------------- PR Review: https://git.openjdk.org/jdk/pull/27041#pullrequestreview-3195015687 PR Review Comment: https://git.openjdk.org/jdk/pull/27041#discussion_r2329176488 PR Review Comment: https://git.openjdk.org/jdk/pull/27041#discussion_r2329179011
