On Thu, 18 Sep 2025 04:50:01 GMT, Leonid Mesnik <[email protected]> wrote:

>> Thanks - though I find this code rather convoluted. We now always extract 
>> the `id` even though we only need it in the `register_vthread_SR == true` 
>> case. I tried different re-arrangements of the code to see if it could be 
>> cleaner, but the JVMTI part is just messy.
>
> Yes, the id is always extracted and the exposure of "raw" id on this level is 
> not the good desing. However, I don't know how to implement this better.

I'm not sure the exposure of "raw" id on this level is not a good design.
The parameter `register_vthread_SR` looks somewhat messy as it is used under 
JVMTI ifdef's only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2361236101

Reply via email to