On Wed, 15 Oct 2025 17:49:11 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Serguei reviews
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java
> line 94:
>
>> 92: public void accept(ClassBuilder builder, ClassElement
>> element) {
>> 93: if (element instanceof FieldModel field &&
>> field.fieldName().stringValue().startsWith("dummy")) {
>> 94: // Defer dummy fields to defer their associated
>> constant pool entries
>
> Nit: This comment is kind of confusing. What does it mean: `defer dummy
> fields`? Do you mean `defer adding dummy fields to the class file`?
I have updated this to indicate this is to hold on to the related constant pool
entries and add them to the end instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25124#discussion_r2433861767
