On Thu, 16 Oct 2025 13:58:09 GMT, Kerem Kat <[email protected]> wrote:

>> Remove 32-bit x86 specific code from the HotSpot Serviceability Agent 
>> following the removal of 32-bit x86 support.
>> 
>> - Removed x86-specific implementations and ifdef blocks.
>> - Renamed files with X86 in the name when they are also used from AMD64, 
>> e.g. `X86Frame` → `AMD64Frame`.
>> - Cleaned up platform detection logic in `PlatformInfo`.
>> - Updated documentation references.
>
> Kerem Kat has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>  - Clean up Hotspot SA after 32-bit x86 removal

Eradicating all references to amd64 is probably worthwhile but a larger 
undertaking. For now changing x86 (implied 32-bit) to amd64, seems reasonable 
to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27844#pullrequestreview-3347645759

Reply via email to