On Tue, 23 Sep 2025 09:29:57 GMT, Fredrik Bredberg <[email protected]> wrote:
> This is a general cleanup after removing `LockingMode` related code. > It's a sub-task of [JDK-8344261](https://bugs.openjdk.org/browse/JDK-8344261). > It includes: > - Removing asserts that are no longer necessary, since we removed legacy > locking and monitor locking. > - Removing or rewriting comments, arguments or functions that are related to > displaced headers. > - Remove "always true" parameter from `MonitorExitStub`. > - Re-type/name metadata in `BasicLock`. > > Tier1-5 passes okay on supported platforms. > > All other platforms (arm, ppc, riscv and s390) has been sanity checked using > Qemu. @fbredber : Thanks for the ping. Tier1 test passes on linux-riscv64 platform. The RISC-V part of the change seems fine modulo one minor nit. src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp line 71: > 69: // basic_lock: must be x10 & must point to the basic lock, contents > destroyed > 70: // temp : temporary register, must not be scratch register t0 or t1 > 71: void unlock_object(Register swap, Register obj, Register lock, Register > temp, Label& slow_case); You might want to rename the third param `lock` to `basic_lock`. void unlock_object(Register swap, Register obj, Register basic_lock, Register temp, Label& slow_case); ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27448#pullrequestreview-3260355920 PR Review Comment: https://git.openjdk.org/jdk/pull/27448#discussion_r2373865694
