On Tue, 28 Oct 2025 20:28:10 GMT, Simon Tooke <[email protected]> wrote:
> This PR addresses [JDK-8370578](https://bugs.openjdk.org/browse/JDK-8370578) > > Under certain circumstances, OpenJDK on macOS maps the hsperf segment private > instead of shared; one of those cases is hit during the tier1 tests, which > test for that. > > This PR allows for shared or private mapping; the purpose of the > intermittently failing test is to test System.map implementation, not JDK > internals. test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java line 192: > 190: macOSbase + macow + space + someNumber + space + > "/.*/bin/java", > 191: // we should see the hs-perf data file, and it should appear > as shared as well as committed > 192: // in the jtreg tests this segment appears private Since you have two sentences now, you should capitalize and use ending periods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28025#discussion_r2474075401
