On Tue, 4 Nov 2025 09:48:20 GMT, Ruben <[email protected]> wrote: >> The C2 exception handler stub code is only a trampoline to the generated >> exception handler blob. This change removes the extra step on the way to the >> generated blob. >> >> According to some comments in the source code, the exception handler stub >> code used to be patched upon deoptimization, however presumably these >> comments are outdated as the patching upon deoptimization happens for >> post-call NOPs only. > > Ruben has updated the pull request with a new target base due to a merge or a > rebase. The pull request now contains 15 commits: > > - Rename deoptHandlerOffsetField -> deoptHandlerEntryOffsetField > - Merge from the main branch > - Address review comments and fix a mistype > - Check for NOP and MOVK separately in NativePostCallNop > - Test for deoptimization in virtual threads > > Change-Id: I9ef51b426d34e9b44a3891f6a45307232f900e5a > - Merge from the main branch > - Address review comments > - Address review comments > - Address review comments > - The patch is contributed by @TheRealMDoerr > - ... and 5 more: https://git.openjdk.org/jdk/compare/1922c4fd...359c2f18
Indeed, the `jmp` size is `2` - I had incorrectly assumed it is `5` as specified here https://github.com/openjdk/jdk/blob/e34a831814996be3e0a2df86b11b1718a76ea558/src/hotspot/cpu/x86/nativeInst_x86.hpp#L412 however that's for a different case. The `10` as size of the deopt handler stub code at https://github.com/openjdk/jdk/blob/e34a831814996be3e0a2df86b11b1718a76ea558/src/hotspot/cpu/x86/x86.ad#L2774 is not correct either - it should be `7`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26678#issuecomment-3499993366
