On Wed, 7 Jan 2026 10:07:02 GMT, Kevin Walls <[email protected]> wrote:
>> Larry Cable has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8327246: updated copyright year. fixed Capitialization nit and >> restructured use of InstanceKlass local as per comments > > src/hotspot/share/oops/instanceKlass.cpp line 2360: > >> 2358: >> 2359: InstanceKlass *ik = k->is_instance_klass() ? InstanceKlass::cast(k) >> : nullptr; >> 2360: > > Looks good with the new local InstanceKlass ik. > Is it possible to not reassign into ik at lines 2386 and 2397, i.e. ik was > the target class as an instanceKlass, but later represents pd or cs, so that > can be hard to follow. I view "ik" like "i" in a for loop, I dont think that defining two additional InstanceKlass'es for "pd" or "cs" when their values are subsequently only used once is merited, but its subjective. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29048#discussion_r2676994050
