On Wed, 24 Dec 2025 07:28:14 GMT, SendaoYan <[email protected]> wrote:

>>> There are references to `nsk.share.gc.GCClassUnloader` in some of the test 
>>> descriptions that need updating. There are also comments like "Next, 
>>> debugger forces debuggee to unload class, using memory stressing techique" 
>>> that need updating. I think you need to review all the test description 
>>> comments.
>>> 
>>> I think someone from the GC team should review the GC test changes since 
>>> WB.fullGC() is a very different approach to ClassUnloader.
>> 
>> The two kinds of incorrect commets has been updated. I think i need some 
>> more time the check all the comments for the touched tests. Thanks for your 
>> reviews.
>
>> The two kinds of incorrect commets has been updated. I think i need some 
>> more time the check all the comments for the touched tests. Thanks for your 
>> reviews.
> 
> All the comments in touched tests has been checked.

> @sendaoYan Can you please update the summary of this PR and Bug and reflect 
> the whole scope of changes.

I have updated to title of this PR and JBS as "Use WB.fullGC() in 
ClassUnloader.unloadClass to force GC for vmTestbase tests". If you have better 
concise summary, please let me known.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28891#issuecomment-3748276900

Reply via email to