On Mon, 26 Jan 2026 23:36:52 GMT, David Holmes <[email protected]> wrote:
>> Chris Plummer has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8375477_coreutils
>> Merge
>> - fix whitespace
>> - get rid of unnecessary throws clause
>> - fix zipped core file support
>
> test/lib/jdk/test/lib/util/CoreUtils.java line 224:
>
>> 222: // Find the core file name in the output.
>> 223: String coreWithPid;
>> 224: if (Platform.isLinux() &&
>> stringWithLocation.contains(ALT_LOCATION_STRING)) {
>
> Why is this only done for Linux when previously it was done for "not
> Windows"? What is the core message on macOS?
Message on Windows:
`# Core dump will be written. Default location:
C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\0\\hs_err_pid71004.mdmp`
And then later in test output you see:
getCoreFileLocation found stringWithLocation =
C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\2\\hs_err_pid80292.mdmp
Found core file
C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\2\\hs_err_pid80292.mdmp,
size = 361mb
I don't have macOS info at the moment. I only ran on macosx-aarch64, and
currently all the core file tests are problem listed on that platform. I'm
doing a run now without them problem listed. Will have results shortly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29284#discussion_r2729744779
