On Thu, 29 Jan 2026 23:56:32 GMT, David Holmes <[email protected]> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: some tweaks for carrier thread JvmtiThreadState initialization
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 61:
> 
>> 59: 
>> 60:   if (JvmtiEnvBase::is_thread_carrying_vthread(thread, thread_oop)) {
>> 61:     // Carrier and virtual threads can temporary share the same 
>> JavaThread.
> 
> Suggestion:
> 
>     // Carrier and virtual threads can temporarily share the same JavaThread.

Also I think this comment block should come before the if statement as it seems 
to be explaining both the if and else cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29436#discussion_r2744016478

Reply via email to