On Fri, 30 Jan 2026 07:08:06 GMT, Serguei Spitsyn <[email protected]> wrote:

>> src/hotspot/share/runtime/continuation.cpp line 92:
>> 
>>> 90:     assert(!_current->is_suspended() ||
>>> 91:            (_current->is_vthread_transition_disabler() && _result != 
>>> freeze_ok), "must be");
>>> 92: #endif
>> 
>> Suggestion:
>> 
>>     assert(!_current->is_suspended() 
>>            JVMTI_ONLY(|| (_current->is_vthread_transition_disabler() && 
>> _result != freeze_ok))
>>            , "must be");
>> 
>> Is this a worthwhile distinction? I guess these days the only way to suspend 
>> is through JVMTI. ??
>
>> Is this a worthwhile distinction? I guess these days the only way to suspend 
>> is through JVMTI. ??
> 
> Good suggestion. JVMTI is the only way to suspend threads.

In fact, we have more suspend/resume related places that could be moved under 
INCLUDE_JVMTI. Then we may want to do a separate cleanup for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29473#discussion_r2761515742

Reply via email to