On Thu, 29 Jan 2026 03:39:18 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with three 
>> additional commits since the last revision:
>> 
>>  - Add new function to handle vDSO
>>  - Remove unneeded change
>>  - Remove 32 bit support
>
> This PR needs a test so I would not suggest dropping 
> TestJhsdbJstackMixedWithVDSOCallCore.java. Regarding our CI, we aren't seeing 
> failures with serviceability/sa/TestJhsdbJstackMixedCore.java, but then our 
> CI does not cover Alpine Linux or Fedora. However, others do test these 
> platforms and likely would not want to see another test failure introduced. I 
> would suggest resolving 
> [JDK-8376284](https://bugs.openjdk.org/browse/JDK-8376284) and apply the same 
> fix here to TestJhsdbJstackMixedWithVDSOCallCore.java.

@plummercj @kevinjwalls 
Thanks a lot for your review! I got your review, but I updated testcase to skip 
if it runs on musl libc. It will fail due to same reason (cannot unwind musl 
libc library) which reported in 
[JDK-8376284](https://bugs.openjdk.org/browse/JDK-8376284).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29400#issuecomment-3854112242

Reply via email to