> Hi > > Please review following fix that remove incorrect assertion. > > Verification should be always done for redefined classes, and is called > `bool Verifier::verify(InstanceKlass* klass, bool should_verify_class, TRAPS)` > where `should_verify_class` and `is_eligible_for_verification` define if > verification should be done or not. > Thus, seems it doesn't make a sense to check `BytecodeVerificationRemote` > during verification. > > Verified that class redefinition tests pass now with > TEST_VM_OPTS="-XX:-BytecodeVerificationRemote" and fastdebug
Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Updated test to verify that JVMTI works with -XX:-BytecodeVerificationRemote - Merg branch 'master' of https://github.com/openjdk/jdk into 8376295 - 8376295: "assert(BytecodeVerificationRemote) failed: Should not be here" when running class redefinition test with -XX:-BytecodeVerificationRemote ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29476/files - new: https://git.openjdk.org/jdk/pull/29476/files/47f00757..279a76ae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29476&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29476&range=00-01 Stats: 558265 lines in 1779 files changed: 281591 ins; 259172 del; 17502 mod Patch: https://git.openjdk.org/jdk/pull/29476.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29476/head:pull/29476 PR: https://git.openjdk.org/jdk/pull/29476
