On Wed, 4 Mar 2026 07:11:50 GMT, SendaoYan <[email protected]> wrote:

> Since ZGC is not the default gc general, and this test already has `@requires 
> vm.flagless`. So the additional `@reauires vm.gc != "Z"` is not needed 
> actually?

I think you are right, but I'd rather keep the @requires explicit in this case 
to avoid confusion if the default GC ever changes or if the vm.flagless setting 
ever changes. It also avoids confusion for the casual reader of the code that 
might think for some reason this one test is allowed to run with ZGC because 
the role of `@requires vm.flagless` is not so obvious.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29959#discussion_r2884602050

Reply via email to