On Wed, 11 Mar 2026 20:50:20 GMT, David Holmes <[email protected]> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   More from @dholmes-ora
>
> test/hotspot/jtreg/serviceability/threads/ThreadInfoTest.java line 38:
> 
>> 36:  * @bug 8323792
>> 37:  * @summary Make sure that jmm_GetThreadInfo() call does not crash JVM
>> 38:  * @library /test/lib
> 
> Please add
> 
> * @module java.management

Fixed

> test/hotspot/jtreg/serviceability/threads/ThreadInfoTest.java line 191:
> 
>> 189: 
>> 190:         public void run() {
>> 191:             while (true) {
> 
> What will cause this thread to terminate?

Oops, right. Make it a daemon thread.

> test/hotspot/jtreg/serviceability/threads/ThreadInfoTest.java line 214:
> 
>> 212: 
>> 213:         public void run() {
>> 214:             while (true) {
> 
> What will cause this thread to terminate?

Fixed

> test/hotspot/jtreg/serviceability/threads/ThreadInfoTest.java line 231:
> 
>> 229:         public void run() {
>> 230:             long i = 0;
>> 231:             while (true) {
> 
> What will cause this thread to terminate?

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30105#discussion_r2936049840
PR Review Comment: https://git.openjdk.org/jdk/pull/30105#discussion_r2936050670
PR Review Comment: https://git.openjdk.org/jdk/pull/30105#discussion_r2936051005
PR Review Comment: https://git.openjdk.org/jdk/pull/30105#discussion_r2936050843

Reply via email to