On Tue, 10 Feb 2026 05:22:11 GMT, David Holmes <[email protected]> wrote:
>> It is. using_class_space is true on LP64, false on 32-bit. Mostly a matter >> of taste. I kept the function here since it conveys more information than >> just a blank ifdef. And this approach (if uses as negation) minimizes >> compile errors on the other side since nobody bothers to build on 32-bit >> anymore. >> >> I have no strong emotions, though. If reviewers prefer it, I'll replace it >> with a blank ifdef _LP64. > > I prefer it simply so we can see this is truly a build-time check and not a > run-time check. Converted all runtime checks to compile-time checks (INCLUDE_CLASS_SPACE) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2964476097
