On Wed, 18 Mar 2026 05:47:12 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Kieran Farrell has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add space > > src/hotspot/share/utilities/vmError.cpp line 1331: > >> 1329: // Avoid large stack allocation on Mac for FD count during >> signal-handling. >> 1330: os::Bsd::print_open_file_descriptors(st, buf, sizeof(buf)); >> 1331: st->cr(); > > Why is there an inconsistency here? On macos there are the empty lines around > “Open File Descriptors” unlike linux. That's a mistake if there are more newlines on apple.... Changes like this should more prominently contain an example of the expected output so people know the intent (but I think it should be without extra newlines). Maybe we can do a simple follow up issue to correct it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27971#discussion_r2972045140
