On Mon, 30 Mar 2026 09:04:32 GMT, Alan Bateman <[email protected]> wrote:
>> The JSON format thread dump generated by HotSpotDiagnosticMXBean.dumpThreads >> and jcmd Thread.dump_to_file currently converts Java longs to json strings. >> This is changed to write longs as numbers when in the "safe range" that can >> be parsed by JS and other system. The changes means that thread >> identifiers, the process ID, and thread counts, are now generated as >> numbers. threadDump.schema.json is used to document the format and is >> updated to reflect the change. A new "formatVersion" property is added to >> make it easier to track changes to the format going forward. >> >> The changes include a test-only update to JSONValue to add support for >> numbers.. While there, it is also updated to bring it closer to current >> proposal/JSON for convenience methods. This will make it easier to replace >> this test library class once a standard API is further along. A number of >> security tests and one JFR test are updated, all trivial changes. >> >> Testing: Tier 1-5. > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'master' into JDK-8381002 > - Compatibility knob > - Change ML_DSA_Test to use map > - Merge branch 'master' into JDK-8381002 > - Initial commit Looks good. Yes like the title update. trivial nit: There are a couple of 3 space indents in test/lib/jdk/test/lib/threaddump/ThreadDump.java (the last 3 "fail" calls in the diff). ------------- Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30467#pullrequestreview-4029704273
