On Tue, 7 Apr 2026 05:43:03 GMT, Leonid Mesnik <[email protected]> wrote:
>> The vmTestbase/nsk/jvmti/scenarios/sampling is updated to run testing in the
>> virtual threads when virtual thread test factory is enabled.
>>
>> The ThreadWrapper is helper class that allows tests execute not only main
>> thread but other threads as virtual threads.
>> It is useful for the pattern
>> `class MyThread extends Thread {...}`
>> The plan is to convert more tests focusing on serviceability tests. Helps
>> to run more jvmti functions for virtual threads.
>>
>> Please note that some tests are still not updated because it requires
>> significant efforts to redesign them. The goal is to update the only simple
>> cases.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - updated doc for ThreadWrapper
> - reverted some tests that can't be really run with virtual threads
> The ThreadWrapper is helper class that allows tests execute not only main
> thread but other threads as virtual threads. It is useful for the pattern
> `class MyThread extends Thread {...}` The plan is to convert more tests
> focusing on serviceability tests. Helps to run more jvmti functions for
> virtual threads.
I'm wondering about the maintainable of this. Do you have to touch update
ThreadWrapper each time that we do any API work on Thread?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30591#issuecomment-4196880390
